microsoft/microsoft-ui-xaml

TabView: Tab closing animation not as good as Chromium Edge

Open

#1,511 opened on Oct 29, 2019

View on GitHub
 (9 comments) (3 reactions) (0 assignees)C# (5,815 stars) (659 forks)batch import
area-TabViewbughelp wantedteam-Controls

Description

Describe the bug The animation when closing a tab is not consistent and looks strange compared to Chromium Edge. Sometimes there will be no animation and sometimes after closing a tab, all tabs disappear and then reappear with very strange animation. (See my gifs below.)

Steps to reproduce the bug

  1. Open an app using TabView.
  2. Open a few tabs.
  3. Close some of them.
  4. Observe the animation when closing tabs.

Expected behavior TabView provides a consistent and smooth animation when closing tabs.

Screenshots Chromium Edge: edge Windows Terminal (also can be reproduced in XAML Controls Gallery): terminal

Version Info NuGet package version: Microsoft.UI.Xaml v2.2.190917002?

Windows 10 version Saw the problem?
Insider Build (18363) Yes
May 2019 Update (18362) Yes
October 2018 Update (17763)
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)
Device form factor Saw the problem?
Desktop Yes
Mobile
Xbox
Surface Hub
IoT

Additional context

Contributor guide

Tech stack
csharp
Domain
frontenddesktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of XAML animationsFamiliarity with WinUI TabView control
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the TabView closing animation implementation in the WinUI codebase, likely in files like TabView.cpp or TabView.xaml. Compare the animation behavior with Chromium Edge's closing animation. Identify where the animation is defined, such as in visual state manager or custom animation storyboards. Adjust the animation to ensure smooth and consistent transition. Refer to existing comments for any pointers. Test on Windows 10 versions mentioned in the issue.