Arcs that are degenerate cause a crash on import fromSVGPathData

Open
#574 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript
Domain
computer-graphics

Research direction

Start at fromSVGPathData and reproduce the crash with M 10 10 A 5 5 0 0 0 10 10. Trace the degenerate-circle intersection handling, then verify that importing this path completes without crashing and add or run the relevant regression test if one is available there.

Written by the indexing model from the issue text.

Description

This happens with e.g. M 10 10 A 5 5 0 0 0 10 10 because it fails to find any intersection points between the two degenerate circles centered on the end points.

Dominant language
TypeScript
Stars
2k
Forks
302
Avg merge
21h 28m
Merged PRs (30d)
5

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/maker.js

All issues in microsoft/maker.js

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.