XTaskQueueSetCurrentProcessTaskQueue SAL should use _In_opt_.
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 65/100
Research direction
Start from the XTaskQueueSetCurrentProcessTaskQueue declaration shown in the issue and inspect the surrounding public API declarations. Update the queue parameter annotation to allow nullptr, then verify that the declaration matches the documented behavior and any related API checks.
Written by the indexing model from the issue text.
Description
The SAL for XTaskQueueSetCurrentProcessTaskQueue is incorrect; it should be allowing a null parameter.
/// <summary>
/// Sets the given task queue as the process wide task queue. The
/// queue can be set to nullptr, in which case XTaskQueueGetCurrentProcessTaskQueue will
/// also return nullptr. The provided queue will have its handle duplicated
/// and any existing process task queue will have its handle closed.
/// </summary>
/// <param name='queue'>The queue to set up as the default task queue for the procces.</param>
STDAPI_(void) XTaskQueueSetCurrentProcessTaskQueue(
_In_ XTaskQueueHandle queue
) noexcept;
That should use _In_opt_.
- Dominant language
- C++
- Stars
- 295
- Forks
- 144
- Avg merge
- 2d 19h
- Merged PRs (30d)
- 2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/libHttpClient
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
microsoft/libHttpClient#964 ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
microsoft/libHttpClient#989 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
microsoft/libHttpClient#909 · 2 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
microsoft/libHttpClient#868 · 6 comments · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
microsoft/libHttpClient#795 ·
All issues in microsoft/libHttpClient
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
AXERA-TECH/ax-llm#77 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
games-on-whales/wolf#509 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
bug-unconfirmed
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
NVIDIA/cuda-samples#453 ·