microsoft/language-server-protocol

Pass the current selection for a Hover Request

Open

#377 opened on Jan 15, 2018

View on GitHub
 (18 comments) (85 reactions) (0 assignees)HTML (12,810 stars) (956 forks)batch import
feature-requesthelp wantedhover

Description

In some languages, such as Haskell, it is meaningful to show the type of an expression, rather than just an identifier.

To allow this, extend the Hover Request to also include a Range if the selection is active.

At the moment in the haskell vscode plugin this is done in a roundabout way using workspace/executeCommand, which means it has to be separately implemented in each client.

Contributor guide

Tech stack
None
Domain
developer experiencetooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
5
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
LSP specification knowledgeJSON RPC understandingBasic programming skills
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Review the existing Hover request specification in the LSP spec (see protocol.hover). Investigate the comments in the issue for discussion on implementation details. The goal is to add an optional `Range` field to the `HoverParams` when a text selection is active. Check the linked Haskell plugin for context on how it currently works around this limitation.