microsoft/language-server-protocol

Pass the current selection for a Hover Request

Open

#377 opened on Jan 15, 2018

View on GitHub
 (18 comments) (85 reactions) (0 assignees)HTML (956 forks)batch import
feature-requesthelp wantedhover

Repository metrics

Stars
 (12,810 stars)
PR merge metrics
 (Avg merge 19h 29m) (12 merged PRs in 30d)

Description

In some languages, such as Haskell, it is meaningful to show the type of an expression, rather than just an identifier.

To allow this, extend the Hover Request to also include a Range if the selection is active.

At the moment in the haskell vscode plugin this is done in a roundabout way using workspace/executeCommand, which means it has to be separately implemented in each client.

Contributor guide

Research direction
Study the current LSP specification for the Hover request, particularly the parameters and response. Understand how a Range could be added to indicate the selection. Look at existing examples of Range parameters in other LSP requests. Propose a modification to the specification document in the repository.
Tech stack
None
Domain
api
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65