microsoft/language-server-protocol

Define a protocol for syntax tokens

Open

#1,063 opened on Aug 7, 2020

View on GitHub
 (7 comments) (0 reactions) (0 assignees)HTML (12,810 stars) (956 forks)batch import
help wantedidea

Description

Is my reading correct, that semantic tokens only add additional information to tokens? Can we trust that the clients will render keywords correctly, if they already have a syntax highlighter (frequently regexp based).

If that's the case, should there be an option to "unset" a type. Just as an example, if you have #ifdefs you could think of giving the LSP server the option of removing syntax coloring from inactive code segments by giving it the token-type None.

Contributor guide

Tech stack
typescript
Domain
apibackend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
LSP protocol basicsSemantic tokens specificationClient server architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Review the existing semantic tokens specification in the LSP repository, particularly the section on token types. Analyze the discussion in the comments to understand the motivation for a 'None' token type. Propose a concrete addition to the protocol document that allows unsetting a token type, ensuring backward compatibility and describing client behavior.
Define a protocol for syntax tokens · microsoft/language-server-protocol#1063 | Good First Issue