microsoft/language-server-protocol

Define a protocol for syntax tokens

Open

#1,063 opened on Aug 7, 2020

View on GitHub
 (7 comments) (0 reactions) (0 assignees)HTML (956 forks)batch import
help wantedidea

Repository metrics

Stars
 (12,810 stars)
PR merge metrics
 (Avg merge 19h 29m) (12 merged PRs in 30d)

Description

Is my reading correct, that semantic tokens only add additional information to tokens? Can we trust that the clients will render keywords correctly, if they already have a syntax highlighter (frequently regexp based).

If that's the case, should there be an option to "unset" a type. Just as an example, if you have #ifdefs you could think of giving the LSP server the option of removing syntax coloring from inactive code segments by giving it the token-type None.

Contributor guide

Research direction
Investigate whether semantic tokens can unset types and propose protocol changes to support removing syntax coloring from inactive code segments.
Tech stack
None
Domain
api
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
LSP protocol knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40