[Bug] HttpxRequestAdapter: The silent deprecation of base_url is actually a breaking change
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
Research direction
Start with HttpxRequestAdapter and inspect how its constructor handles base_url after change #481; compare the reported workaround with the parameter's current behavior. Clarify whether the intended outcome is deprecating the constructor parameter or restoring its effect, then verify the chosen behavior with regression coverage.
Written by the indexing model from the issue text.
Description
#481 actually introduced a breaking change.
The parameter base_url is still there but no matter what value you provide, it's ignored. We did not pass a value for http_client, and only specified the base_url like this:
request_adapter = HttpxRequestAdapter(
authentication_provider, base_url="https:/example.com"
)
We run this in a Fabric notebook where the version of the package was not pinned. So the moment it downloaded the new version, it failed with a misleading error.
To fix it, we had to do the following work around:
request_adapter = HttpxRequestAdapter(authentication_provider)
request_adapter.base_url = "https:/example.com"
I think it's best to deprecate this base_url parameter in the constructor if it's not supposed to be used.
- Dominant language
- Python
- Stars
- 31
- Forks
- 39
- Avg merge
- 11h 45m
- Merged PRs (30d)
- 42
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/kiota-python
-
help wanted type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
microsoft/kiota-python#477 · 2 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
microsoft/kiota-python#745 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
microsoft/kiota-python#744 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 72/100
microsoft/kiota-python#737 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
microsoft/kiota-python#722 · 1 comment ·
All issues in microsoft/kiota-python
Similar issues
-
documentation help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
simonw/sqlite-utils#872 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100