runInTerminal reverse-request missing cwd key
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
Start by locating the Java debug server code that constructs the DAP runInTerminal reverse request, then compare its arguments with the linked DAP specification. The work is done when the request includes the mandatory cwd key and the relevant request behavior is covered by the project's tests.
Written by the indexing model from the issue text.
Description
According to the DAP specification, the cwd key in the runInTerminal request is mandatory.
https://microsoft.github.io/debug-adapter-protocol/specification#Reverse_Requests_RunInTerminal
however, the java debug server sends the request without this key:
2018-12-20 00:03:04,861 - DEBUG - Message received: {'command': 'runInTerminal', 'arguments': {'kind': 'integrated', 'title': 'Java Debug Console', 'args': ['/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre/bin/java', '-agentlib:jdwp=transport=dt_socket,server=n,suspend=y,address=localhost:53159', '-Dfile.encoding=UTF-8', '-cp', '/Users/ben/.vim/bundle/vimspector/support/test/java/test_project/target/classes', 'com.vimspector.test.TestApplication', 'hello', 'world!']}, 'seq': 2, 'type': 'request'}
of course, clients could work around this, but it would be nice for the server to include the required parameter.
- Dominant language
- Java
- Stars
- 409
- Forks
- 204
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 4
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/java-debug
-
ai-triaged bug
Difficulty 4/5 3-5 days Newbie friendliness 35/100
microsoft/java-debug#611 · 2 comments ·
-
ai-triaged enhancement
Difficulty 4/5 3-5 days Newbie friendliness 35/100
microsoft/java-debug#608 · 3 comments ·
-
ai-triaged question
Difficulty 5/5 Over a week Newbie friendliness 30/100
microsoft/java-debug#597 · 1 comment ·
-
ai-triaged bug
Difficulty 4/5 3-5 days Newbie friendliness 25/100
microsoft/java-debug#588 · 1 comment ·
-
ai-triaged question
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
microsoft/java-debug#582 · 1 comment ·
All issues in microsoft/java-debug
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
elastic/gradle-plugins#157 ·
-
enhancement Tools
Difficulty 1/5 Under an hour Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
apache/rocketmq-dashboard#5008 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
DETECT_PARAMETER_NAMES=false silently disables @ConstructorProperties-based Creator detection too Open
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
FasterXML/jackson-databind#6229 ·