microsoft/cpprestsdk

web_proxy doesn't work when using port numbers in address

Open

#57 opened on Jan 18, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (7,596 stars) (1,670 forks)batch import
bughelp wanted

Description

I tested this with v2.7.0 and v2.1.0 (with vc12 and vc14 on win10 and server2012), on about 20 proxy machines I know are good. I though it had worked with some old cpprest version but probably not. (I know the proxies are fine as I use them fine through libcurl).

Minimal example: I get the error "web::uri_exception: provided uri is invalid":

#include <cpprest/http_client.h>
int main() {
    try {
        //web::http::client::web_proxy wp2(L"123.123.123.123"); //OK
        web::http::client::web_proxy wp2(L"123.123.123.123:1234"); //Error
        std::cout << "OK" << std::endl;
    }
    catch (const std::exception& exc) {
        std::cerr << exc.what() << std::endl;
    }
}

Contributor guide

Tech stack
cpp
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the web proxy constructor and the URI parsing logic in the cpprestsdk library. Specifically, examine how addresses with port numbers are handled compared to addresses without ports. Look at the web proxy class definition and the underlying URI validation to identify where the invalid URI error is thrown. Consider adjusting the parsing to accept address:port format.