microsoft/cpprestsdk

reserved identifier violation

Open

#14 opened on Nov 10, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (7,596 stars) (1,670 forks)batch import
enhancementhelp wanted

Description

I would like to point out that identifiers like "_CASA_HTTP_CLIENT_H" and "_Value" do not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

Contributor guide

Tech stack
cpp
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++ knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
95
Research direction
The issue identifies reserved identifiers in http client.h and json.h. The fix involves renaming CASA HTTP CLIENT H and Value to conform to C++ naming conventions. See the linked lines in the issue and the CERT guideline. No further discussion needed.