Incorrect orderNumber in SendChunkedContent

Open Beginner friendly
#705 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
65/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
csharp
Domain
tooling

Research direction

Open src/BinSkim.Sdk/CompilerDataLogger.cs and inspect SendChunkedContent, especially how orderNumber is calculated from the partition loop. Reproduce the case where totalNumber or size is 2 and verify that the generated order numbers are sequential partition numbers, ending with 2 rather than 8193.

Written by the indexing model from the issue text.

Description

In src/BinSkim.Sdk/CompilerDataLogger.cs, orderNumber in SendChunkedContent should be based on number of partitions rather than i which is based on size. For example, if totalNumber or size is equal to 2, the two orderNumber values will be 1 and 8193. The second orderNumber should be 2.

One possible fix is something like { "orderNumber", (i /s_chunkSize + 1).ToString() },

Dominant language
C#
Stars
860
Forks
178
Avg merge
5d 2h
Merged PRs (30d)
11

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/binskim

All issues in microsoft/binskim

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.