Highlighting breaks when casting a variable called `type`

Open
#992 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript
Domain
tooling

Research direction

Reproduce the two TypeScript examples in a VS Code highlighting environment, comparing the current and expected behavior shown in the issue. Then inspect the repository's TypeScript TextMate grammar rules for angle-bracket and as casting, and verify that highlighting continues correctly after both forms, including when a variable is named type.

Written by the indexing model from the issue text.

Description

JavaScript and TypeScript Nightly version: v5.3.20230923

Hi there, an issue occurs when both using <> and as casting.

Code

Using <> casting with newline after <:

export function main() {
  const type = ``;
  const variable = <
  'dog' | 'cat'>type;

  return;
}

The remaining lines Highlights weirdly, or even stops:

current behavior expected behavior
image image

Using as casting with already declared variable:

export function main() {
  const type = ``;
  let variable = ``;
  variable = type as 'dog' | 'cat';
  return;
}
current behavior expected behavior
image image
Dominant language
TypeScript
Stars
471
Forks
149
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/TypeScript-TmLanguage

All issues in microsoft/TypeScript-TmLanguage

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.