VSCode Syntax highlighting broken when using TypeScript multiline generics in ES6 object function shorthand syntax
@mjbvz is already working on this.
Since Dec 1, 2021.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- typescript, vscode
- Domain
- developer-experience, tooling
Research direction
Reproduce the issue in VS Code with the TypeScript snippet, comparing the multiline generic with the single-line form. Then inspect the repository's TypeScript TextMate grammar files to find the rule handling object function shorthand and multiline generics. Done means both forms receive correct syntax highlighting without affecting the surrounding function body.
Written by the indexing model from the issue text.
Description
Does this issue occur when all extensions are disabled?: Yes
- VS Code Version: 1.62.3
- OS Version: macOS 11.6.1
Steps to Reproduce:
- Create a typescript file with the following code:
const obj = {
fn<
K extends string
>(_: K) {
const a = 'a';
function _f() {
const b = 'b';
return b;
}
return a;
},
};
const obj2 = {
fn<K extends string>(_: K) {
const a = 'a';
function _f() {
const b = 'b';
return b;
}
return a;
},
};
- Notice how the syntax highlighting is broken in the first object declaration:
- Dominant language
- TypeScript
- Stars
- 471
- Forks
- 149
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/TypeScript-TmLanguage
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
microsoft/TypeScript-TmLanguage#1071 ·
-
triste Open
Difficulty 5/5 Over a week Newbie friendliness 5/100
microsoft/TypeScript-TmLanguage#1078 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
microsoft/TypeScript-TmLanguage#1076 · 6 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
microsoft/TypeScript-TmLanguage#1074 · 2 comments ·
-
Difficulty 1/5 1-3 hours Newbie friendliness 58/100
microsoft/TypeScript-TmLanguage#1066 · 1 comment ·
All issues in microsoft/TypeScript-TmLanguage
Similar issues
-
bug(cli): hapi doctor inline-media prints a fabricated B:\ helper-script path in packaged installs Open
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Crush Open
Difficulty 1/5 Under an hour Newbie friendliness 85/100
catppuccin/catppuccin#3125 ·
-
Add a SECURITY.md Open
Difficulty 1/5 Under an hour Newbie friendliness 90/100
ElementsProject/cln-application#167 · 1 comment · 1 reaction ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Quantco/pnpm-licenses#17 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100