Messed syntax highlighting
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 42/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- typescript
- Domain
- tooling
Research direction
Start by reproducing the reported snippet in VS Code 1.56.2 with extensions disabled and compare highlighting with and without the semicolon or blank line. The payload names no source file or test; done means the TypeScript grammar keeps the following code highlighted correctly when the declaration has no semicolon.
Written by the indexing model from the issue text.
Description
Does this issue occur when all extensions are disabled? ✔️
- VS Code Version: 1.56.2
- OS Version: Windows 10
- Language: TypeScript
Description:
- When a type declaration statement without an ending semicolon is followed directly by some specific statement, like a function call, the syntax highlighting of the following codes becomes messed up. If we add a semicolon at the end, or a blank line, the syntax highlighting will return to normal. Though this bug could be easily avoided by users, I still recommend it be fixed, since syntax highlighting should always synchronize with compilers, and such codes can be successfully compiled by tsc.
How to Reproduce:
- Copy the following snippet into VS Code
async function foo(): Promise<number> { return Promise.resolve(0); } type Type = string foo().then(async bar => { if (typeof (bar) == "number") console.log("number"); const year = 2021; }); - Check out the syntax highlighting, it should be something like the following image:
- Dominant language
- TypeScript
- Stars
- 471
- Forks
- 149
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/TypeScript-TmLanguage
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
microsoft/TypeScript-TmLanguage#1071 ·
-
triste Open
Difficulty 5/5 Over a week Newbie friendliness 5/100
microsoft/TypeScript-TmLanguage#1078 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
microsoft/TypeScript-TmLanguage#1076 · 6 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
microsoft/TypeScript-TmLanguage#1074 · 2 comments ·
-
Difficulty 1/5 1-3 hours Newbie friendliness 58/100
microsoft/TypeScript-TmLanguage#1066 · 1 comment ·
All issues in microsoft/TypeScript-TmLanguage
Similar issues
-
bug(cli): hapi doctor inline-media prints a fabricated B:\ helper-script path in packaged installs Open
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Crush Open
Difficulty 1/5 Under an hour Newbie friendliness 85/100
catppuccin/catppuccin#3125 ·
-
Add a SECURITY.md Open
Difficulty 1/5 Under an hour Newbie friendliness 90/100
ElementsProject/cln-application#167 · 1 comment · 1 reaction ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Quantco/pnpm-licenses#17 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100