Regex on new line breaks js/ts highlighter

Open
#1,024 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript
Domain
tooling

Research direction

Reproduce the issue with the provided TypeScript snippet in VS Code using the TypeScript language mode, then inspect the repository's TypeScript TextMate grammar files. Compare the highlighting with the expected example and verify that placing the regular expression on a new line no longer breaks highlighting for the following code.

Written by the indexing model from the issue text.

Description

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version:
1.85.2
c8a36a69377856369f139f39ee56dd3838130fbf
x64
  • OS Version: n/a

Putting a regular expression on a new line in JavaScript or TypeScript breaks the highlighter.
Steps to Reproduce:

  1. paste this:
1
	/ f(/u/g)
function f(_: RegExp) {
	return 1;
}
  1. make sure the language mode is set to TypeScript
    Expected:
    Same highlighting as this:
    u replaced with e

Actual:
Highlighting is wrong after the first line.

Theme: @id:vscode.theme-defaults: Dark +

Dominant language
TypeScript
Stars
471
Forks
149
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/TypeScript-TmLanguage

All issues in microsoft/TypeScript-TmLanguage

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.