microsoft/Terminal

Add a `path` parameter to `toggleShaderEffects`

Open

#9,898 opened on Apr 19, 2021

View on GitHub
 (8 comments) (2 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-RenderingArea-SettingsHelp WantedIssue-TaskProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Add an "enablePixelShader" setting, which can be set to true or false.

If set to "false", but a valid pixelShaderPath was specified, this would enable Windows Terminal to be started without the pixel shader visible, but available at the press of a key combination.

Contributor guide

Research direction
Examine the existing pixel shader settings and keyboard handling code to understand how to add the enablePixelShader setting and modify toggleShaderEffects.
Tech stack
cpp
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30