microsoft/Terminal

Validate that VT adapter tests cover all mock possibilities

Open

#987 opened on May 24, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-CodeHealthArea-VTHelp WantedIssue-TaskProduct-Conhost

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

All of the various mock definitions don't seem to be in use. When I stood up the original parser years ago and wrote the mock, every mock was checked somehow. Over time, it probably decayed and the only thing left is that the mock has to be implemented to satisfy compilation of the interface.

Originally posted by @miniksa in https://github.com/microsoft/terminal/pull/891/review_comment/create

The goal here would be to run through all the tests and ensure that the mocks are involved somehow in each operation to validate that we're getting what we expect back through the adapter interface for all potential results.

Contributor guide

Research direction
Examine the existing VT adapter tests and mocks to identify which mocks are not exercised. Ensure each mock method is used in at least one test case.
Tech stack
None
Domain
testing
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Unit testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50