microsoft/Terminal

Show error state in progress ring of tab

Open

#9,481 opened on Mar 13, 2021

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-UserInterfaceHelp WantedIssue-TaskProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Description of the new feature/enhancement

If an application reports progress via OSC 9;4, Windows Terminal nowadays shows that in the task bar and in the tab header (https://github.com/microsoft/terminal/pull/8133). However, if the progress report has the error or warning state, that information goes only to the task bar. I'd like the tab header to display the error or warning, too.

Related to https://github.com/microsoft/terminal/issues/6700 and https://github.com/microsoft/terminal/issues/9435#issuecomment-796667902.

Proposed technical implementation details (optional)

Could perhaps change the color of the progress ring. I don't see any color or error property in Microsoft.UI.Xaml.Controls.ProgressRing, though.

Contributor guide

Research direction
Investigate how the tab progress ring is currently rendered in the Terminal's XAML code and locate where the progress state (normal, error, warning) is handled. Determine if the WinUI ProgressRing supports color changes natively or if a custom control needs to be implemented. Look at existing PRs #8133 and related issues #6700 and #9435 for context. The goal is to modify the tab header to display error/warning state visually, possibly by changing the progress ring color or adding an overlay.
Tech stack
None
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++XAML
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65