microsoft/Terminal

Detect and disable settings that are disabled by an OS setting

Open

#8,901 opened on Jan 26, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-SettingsUIHelp WantedIssue-TaskProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Description of the new feature/enhancement

There are a few app settings that end up getting ignored if the OS has certain settings:

  • Appearance > Theme is ignored if the system is in HC mode
  • Appearance > Disable pane animations is disabled if Windows disables all animations
  • Profile > Appearance > Enable acrylic is ignored if the system is in HC mode, or the Disable transparency option is enabled
  • from #12692:

    While turning on Acrylic on the windows terminal if the windows setting Transparancy effects is not turned on (Windows Settings -> Customize -> Colors -> Transparancy effects) the acrylic effect will not take effect. Feedback about this feature should be given to the user while trying to turn acrylic on without this setting on.

It’d be nice to have an indication when a setting is not going to do anything. For example, the OS Settings app has these: OS Disabled setting 1 OS Disabled setting 2

Contributor guide

Research direction
Investigate how to query Windows OS settings (e.g., high contrast mode, animation toggle, transparency toggle) and modify the Terminal settings UI to disable corresponding options when the OS setting is active. Reference issue #12692 for acrylic transparency.
Tech stack
cpp
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Windows development environmentC++ basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50