microsoft/Terminal

Code Health: Cleanup manual StartBringIntoView once fixed in WinUI

Open

#8,833 opened on Jan 20, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-CodeHealthHelp WantedIssue-TaskProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

As a part of a workaround for https://github.com/microsoft/microsoft-ui-xaml/issues/3945 we have introduced a manual call to StartBringIntoView (https://github.com/microsoft/terminal/pull/8832).

We would like to cleanup this code, once the fix is introduced in the TabView. There is already a PR for the upstream issue here: https://github.com/microsoft/microsoft-ui-xaml/pull/3966.

Contributor guide

Research direction
Check if the upstream WinUI fix (PR #3966) has been merged. If so, remove the manual StartBringIntoView call and related code from the Terminal codebase. Verify that TabView behavior works correctly without the workaround.
Tech stack
None
Domain
frontend
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++WinUI
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85