microsoft/Terminal

WM_NCHITTEST returns HTCAPTION for client area and tabs

Open

#8,795 opened on Jan 15, 2021

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-UserInterfaceHelp WantedIssue-BugPriority-2Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Description of the new feature/enhancement

Please consider placing the tabs into the client area instead of the title bar. Right now the tabs are in the correct place only with setting "showTabsInTitlebar": false,. This will cause problems with softwares that utilize the title bars.

Snipaste_2021-01-14_22-36-17 Default settings

Snipaste_2021-01-14_22-32-35 "showTabsInTitlebar": false,

Proposed technical implementation details (optional)

Take a look at Edge browser. Edge used to place everything in the title bar as well, but now it has been fixed.

Snipaste_2021-01-14_22-39-10

Contributor guide

Research direction
Investigate the WM NCHITTEST handling in the terminal codebase and modify it to return HTCLIENT for client area instead of HTCAPTION when tabs are in title bar.
Tech stack
cpp
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Windows API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65