microsoft/Terminal

Missing operator delete/delete[] for some allocated objects

Open

#875 opened on May 17, 2019

View on GitHub
 (7 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-CodeHealthHelp WantedIssue-BugProduct-Conhost

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Hi.

Looks like there are few places in the Terminal code where I can suspect a memory leaks due to missing operator delete or operator delete[]. These allocation sites can be grouped into following:

Here is my gist with quite a simple grep foroperator new calls - https://gist.github.com/dreamer-dead/c43248466fc4d445378b4dfba80d8d25

Is this an intentional behaviour or a bug that should be fixed?

Contributor guide

Research direction
Investigate each allocation site listed in the gist (e.g., ConptyConnection.cpp line 191, TermControl.cpp line 281) and add missing operator delete/delete[] calls. Consider using RAII or smart pointers to prevent leaks.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Memory Management
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65