microsoft/Terminal

[Feature request] [Settings UI] Import a color scheme from a json file

Open

#8,639 opened on Dec 23, 2020

View on GitHub
 (12 comments) (1 reaction) (0 assignees)C++ (3,212 forks)batch import
Area-SettingsUIHelp WantedIssue-FeatureProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Description of the new feature/enhancement

I was trying the new settings UI and I found that adding a new color scheme is actually harder than using the json editor. When using the json editor I can directly copy the colors. But with settings UI I cannot do that anymore, which frustrates me a bit. I'd like to propose the feature to import a json file as color scheme. This way all those color schemes in https://github.com/mbadolato/iTerm2-Color-Schemes/tree/master/windowsterminal can be used easily.

This is inspired by iTerm2 on macOS.

Proposed technical implementation details (optional)

Ideally it should be just adding a button, parse the json & save.

Contributor guide

Research direction
Investigate the Settings UI code for color schemes, specifically how manual color input works. Then add a button to import from JSON, parse the JSON schema used by iTerm2 Color Schemes, and save the scheme.
Tech stack
None
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++Windows Terminal codebase knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45