microsoft/Terminal

initialRows/initialColumns still doesn't work quite right

Open

#8,527 opened on Dec 8, 2020

View on GitHub
 (17 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-UserInterfaceHelp WantedIssue-BugPriority-2Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

By default WT starts with `"initialRows": 30', and this is true when there is not the tab row. After opening the first tab, tha tab row shows up and WT really displays 28 rows (it conserves the window height).

Is there an option to conserve the `initiaRows', 30, for example? (the window height should increase a bit).

Contributor guide

Research direction
Investigate the window height calculation logic in the terminal code, specifically how the tab row height is accounted for when setting initialRows. Look at the C++ code that handles the initialRows setting and the window resize event.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75