microsoft/Terminal

Terminal should always wrap drag-dropped paths in double quotes

Open

#8,109 opened on Oct 30, 2020

View on GitHub
 (23 comments) (3 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-TerminalControlHelp WantedIssue-TaskPriority-3Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Environment

Microsoft Windows [版本 10.0.18363.1139] Windows Terminal [ powershell] 版本: 1.3.2651.0 python 3.7

Steps to reproduce

1.write the followings code xx.py import sys with open(sys.argv[1]) as f: pass 2.create a txt as "xxx(1).txt", the name must include"()" 3:open windows terminal powershell, cd to the xx.py directory input “python xx.py” drop the txt into terminal run 4.if the filename contain "(xx)" can not resolve the path.

Expected behavior

it worked in cmd open the file success

Actual behavior

FileNotFoundError: [Errno 2] No such file or directory: 'C:\Users\xx\Desktop\\input'

Contributor guide

Research direction
Trace the drag drop event handler in the Terminal codebase, likely in `TerminalPage.cpp` or `DropHandler.cpp`, to see where paths are inserted into the input buffer and ensure they are wrapped in double quotes when they contain spaces or parentheses.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65