microsoft/Terminal

LVB Gridlines do not transit ConPTY (Win32 "underline", overline, left/right)

Open

#8,037 opened on Oct 25, 2020

View on GitHub
 (9 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-OutputHelp WantedIssue-TaskPriority-2Product-Conpty

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Windows 10, Windows Terminal, Version: 1.3.2651.0

Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd]
Windows Terminal version (if applicable):

Any other software?

I use

-- SetConsoleMode(hStdin, ENABLE_WINDOW_INPUT | ENABLE_LVB_GRID_WORLDWIDE ) -- I do "| COMMON_LVB_UNDERSCORE' on the attributes of CHAR_INFO 'line' -- WriteConsoleOutput(... line );

I am 95% sure the rest of the code is valid -- because I can do colors, etc.

Expected behavior

-- characters should be underlined.

Actual behavior

-- no underline

Contributor guide

Research direction
Investigate how LVB gridline attributes (underline, overline, left/right) are handled in the ConPTY layer and why they are not being transmitted to the terminal.
Tech stack
cpp
Domain
cliapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++GitWindows API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35