microsoft/Terminal

Add Optional Cursor Properties to Color Schemes

Open

#764 opened on May 14, 2019

View on GitHub
 (6 comments) (8 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-SettingsHelp WantedIssue-FeatureProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

There are several fields assigned against profiles that feel like they would be better placed in schemes (or at least duplicated to schemes):

  • cursorColor
  • cursorShape
  • fontFace
  • fontSize

There are two options for these properties that could be utilised:

  1. Remove them from the profile and add them to schemes, updating the current schemes with default values.
  2. Leave them in the profile and have them act as an override when present, similar to what background is doing currently.

Additionally, it may be worth actually removing the default background value, to allow the theme background to actually work by default.

Contributor guide

Research direction
Examine the current color scheme and profile JSON structures to understand how cursorColor, cursorShape, fontFace, and fontSize are assigned. Consider the two proposed options and evaluate which approach aligns with the existing design patterns. Look at how background is handled as an override example.
Tech stack
c
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
understanding of Windows Terminal settingsJSON or settings structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65