microsoft/Terminal

Use a Clip rect for Pane animations instead of the Width/Height

Open

#7,436 opened on Aug 27, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-UserInterfaceHelp WantedIssue-TaskPriority-3Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

follow up from #7364

Looking at this doc:

An animation is independent if it has any of these characteristics:

  • The Duration of the animation is 0 seconds (see Warning)
  • The animation targets UIElement.Opacity
  • The animation targets a sub-property value of these UIElement properties: Transform3D, RenderTransform, Projection, Clip
  • The animation targets Canvas.Left or Canvas.Top
  • The animation targets a Brush value and uses a SolidColorBrush, animating its Color
  • The animation is an ObjectAnimationUsingKeyFrames

emph added

Right now we're stuck being a dependent animation, because we're animating the Width or Height. But we might be able to use Clip to achieve the same effect.

I'm no XAML wizard, so that'll require another day of learning to figure out, but I figured I'd write these notes down before I forgot.

Might even be able to get us #7365 for free.

Contributor guide

Research direction
Implement clip rect animation for panes according to the Windows UI animation guidelines to make animations independent and avoid performance issues.
Tech stack
cpp
Domain
desktop
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++XAML
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30