microsoft/Terminal

While mouse over on titlebar, allow to react to Ctrl+MouseScroll human-events on to active tab.

Open

#7,427 opened on Aug 27, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-InputHelp WantedIssue-TaskPriority-3Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Description of the new feature/enhancement

Then mouse is over WindowsTerminal's titlebar, Ctrl+MouseScroll events should be handled the same way as mouse would be over inside terminal window.

I am using Windows Terminal with SSH client to connect to linux remotes. And then I open linux htop cli-utility I cannot rezoom Windows terminal.

Proposed technical implementation details (optional)

Ctrl+mouse_scroll should allow zoom-in/out currently active tab THEN mouse is over windows-terminal's titlebar's blank space.

Currently I need to exit htop to rezoom and then reenter htop.

To replicate original problem:

  1. Enter powershell via WindowsTerminal.
  2. Execute: $ ssh user@hostname -p 22 -i ~/.ssh/id_ed25519 $ htop
  3. Try to rezoom with Ctrl+MouseScroll , you cannot.
  4. Exit htop by pressing Q.
  5. Now you can rezoom with Ctrl+MouseScroll in WindowsTerminal

Contributor guide

Research direction
Investigate the terminal's mouse input handling code, specifically how Ctrl+MouseScroll is processed for the tab content but not for the titlebar. Look at the window message loop and determine how to propagate scroll events from titlebar to the active terminal tab.
Tech stack
cpp
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40