microsoft/Terminal

Pane opening animation should not flash the default pane backdrop

Open

#7,365 opened on Aug 21, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-UserInterfaceHelp WantedIssue-TaskPriority-3Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

follow up to #7364

When we open a new pane there's a brief time when you can see the pane background color as the new pane slides in. This is because we immediately create the Row/Col definitions, so even if we animate the first pane getting smaller, the first pane only has half the parent grid to render into.

A solution we could do is use the background brush from the first child as the background of the parent pane, until the animation is finished. Then revert back to transparent. This will make the backgroud behind the pane sliding in look like it's the same as the first pane. This won't really help for background images, but I think this is a reasonable compromise.

Contributor guide

Research direction
Look at the pane opening animation code. Find where the default backdrop color is applied and where the animation transitions. Consider using the first child's background brush as the parent pane's background until the animation completes, then revert to transparent.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75