microsoft/Terminal

Color picker window closes unexpectedly when clicking on the combobox multiple times

Open

#7,092 opened on Jul 27, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-UserInterfaceHelp WantedIssue-BugPriority-3Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Environment

Windows build number: 10.0.19041.388
Windows Terminal version: 1.1.2021.0

Steps to reproduce

  1. Right click on a tab
  2. Click "Color..."
  3. Click "Custom..."
  4. Click "More"
  5. Click on the combobox with RGB and HSV
  6. Click on an empty area, so the combobox closes
  7. Click on the combobox again

Expected behavior

The combobox opens again

Actual behavior

The color picker window closes

Contributor guide

Research direction
Trace the event handler for the combobox dropdown in the color picker dialog. Look for focus or mouse events that might cause the parent window to close.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60