microsoft/Terminal

Transparent background doesn't become transparent foreground when rendered in reverse video

Open

#7,014 opened on Jul 22, 2020

View on GitHub
 (31 comments) (14 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-RenderingHelp WantedIssue-TaskProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

The new Preview 1.2.2022.0 seems to fix all the VT colors issues I observed before, except one last case:

When the background color is the default (49), it is correctly kept transparent, but if the foreground color is transparent, which is possible when the background is 49 and then the colors are reversed using 7, it is rendered as black instead of transparent.

image echo -e "\e[31m\u2580\e[7m\u2580\e[m" echo -e "\e[31m\u2590\e[7m\u25A0\e[27m\u258C\e[m"

In both cases, there should be no black square, the acrylic transparency should show through instead.

Contributor guide

Research direction
Examine how the terminal handles reverse video (SGR 7) in conjunction with default background (49) and foreground transparency. Look at the rendering pipeline for VT sequences, specifically the color reversal logic and how it interacts with transparency. Check if there is a missing handling for default foreground when reversed.
Tech stack
cpp
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++VT sequencesterminal rendering
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40