microsoft/Terminal

Normalize terminal padding in maximized or fullscreened windows

Open

#6,495 opened on Jun 13, 2020

View on GitHub
 (2 comments) (4 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-TerminalControlHelp WantedIssue-TaskProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Description of the new feature/enhancement

When the window is in an un-maximized state, Terminal snaps window resizes to the closest character, which makes sense -- this way, the terminal padding on all 4 edges is what it's set to in settings.json.
However, when the window is maximized or in fullscreen, Terminal's size depends on the size of the monitor, which means the padding is often mismatched. When this happens, Terminal preserves the top and left padding. This makes some graphical CLI programs look a bit odd:

A full-screened Terminal with weechat running with equal padding on the left and top sides, but greater than usual padding on the right and especially the bottom

It might be nice to have an option to make the left-right and top-bottom paddings equal in this situation, so that the terminal content is centred within the window rather than at the top left.

Proposed technical implementation details (optional)

Of course, the padding setting should still be used as a minimum padding, and I think it makes sense to have this as a per-profile option (it makes more sense when you're running full-screen CLI programs like weechat, than if you're just running a shell.)

Contributor guide

Research direction
Explore the existing padding logic in TerminalControl and implement a setting to center terminal content when the window is maximized or fullscreened. Look at how the padding is calculated and where window state is checked.
Tech stack
cpp
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75