microsoft/Terminal

Access keys for new tab drop down menu items

Open

#6,213 opened on May 26, 2020

View on GitHub
 (1 comment) (2 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-UserInterfaceHelp WantedIssue-FeatureProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Description of the new feature/enhancement

Currently, bringing up the new tab drop down requires using arrow keys to move to each option. It would make accessibility easier if users could press access keys that correlate with each entry to jump to that entry or cycle through similarly identified entries.

Proposed technical implementation details (optional)

One possible solution: If the menu looks like the following,

  • PowerShell
  • Command Prompt
  • PSCore
  • Settings
  • Feedback
  • About

It would be helpful if a user could press p twice to select "PSCore" or c once to select "Command Prompt". This may be doable simply by setting AccessKey for each MenuFlyoutItem in TerminalPage::_CreateNewTabFlyout.

Another possible solution would be to support _ syntax, mirroring WPF's implementation in the config JSON's profile names.

Contributor guide

Research direction
Learn about UWP MenuFlyoutItem AccessKey property and add it to the relevant items in TerminalPage:: CreateNewTabFlyout.
Tech stack
cpp
Domain
frontendaccessibility
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65