microsoft/Terminal

Background image should (optionally?) render pixel-for-pixel rather than scaling with the system scale

Open

#5,480 opened on Apr 23, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-TerminalControlHelp WantedIssue-BugPriority-3Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Description of the new feature/enhancement

This might be related to #2370, but it addresses a slightly different problem.

Currently, Windows Terminal scales the background image according to your system UI scale. So, for example, if your UI scale is set to 150% in Windows Settings, and you set a 100×100-pixel background image with backgroundImageStretchMode: none, the image will be rendered at 150×150. This might not be what you want, since the scaling will blur sharp edges, and the image will be much larger than you might have expected.

Proposed technical implementation details (optional)

There should be some way to indicate that we want our background image to render pixel-for-pixel, rather than be enlarged according to the UI scale.

Or else maybe it should simply render pixel-for-pixel by default. This was my expectation; not sure if it matches the expectation of others.

Contributor guide

Research direction
Investigate how the current DPI scaling is applied to background images in the renderer, and implement a new property to opt in to pixel for pixel rendering.
Tech stack
cpp
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++GitWindows Programming
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70