microsoft/Terminal

Make a second `LibraryIncludes.h` that includes WIL and TIL & have it at the bottom of every `precomp.h`

Open

#5,182 opened on Mar 30, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-CodeHealthHelp WantedIssue-TaskProduct-Meta

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Can you file a follow-on task to perhaps make a second LibraryIncludes.h that includes WIL and TIL and have it at the bottom of every precomp.h?

I feel like you've done this to like 6 more projects as of this PR and I bet it will just keep coming.

We should probably put all super-powered headers at the bottom of every precomp.h.

Originally posted by @miniksa in https://github.com/microsoft/terminal/pull/5131

Contributor guide

Research direction
Locate all precomp.h files in the repository and append an #include directive for a new LibraryIncludes.h at the end of each. The new header should include WIL and TIL headers.
Tech stack
cpp
Domain
build system
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90