microsoft/Terminal

Pane focus movement doesn't remember where it came from

Open

#4,692 opened on Feb 22, 2020

View on GitHub
 (9 comments) (4 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-UserInterfaceHelp WantedIssue-BugPriority-2Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Steps to reproduce

create a vertical split, then on the right pane, create a horizontal split somewhat like this :

|-----------|
|    |  2   |
|  1 |______|
|    |   3  |
|____|______|

if you move focus from 1 to 2 by moveFocus right then move focus from 2 to 3 by moveFocus down then move focus from 3 to 1 by moveFocus left then moveFocus right

Expected behavior

The focus should go back to 3. Otherwise toggling between 1 and 3 becomes a painful, especially if 2 is ends up more complicated with more panes.

Actual behavior

focus goes to 2

Contributor guide

Research direction
Investigate the focus movement logic in pane splitting to ensure that moving focus back remembers the previous pane.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65