microsoft/Terminal

TestMouseWheelReadConsoleInputHelper tests are flaky

Open

#4,494 opened on Feb 6, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-CodeHealthArea-InputHelp WantedIssue-TaskProduct-Conhost

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

In the InputTests, there are a handful of them that inject mouse events into the window handle.

They center around the method TestMouseWheelReadConsoleInputHelper.

They tend to fail when there are two input events in the queue instead of just the one they expect.

My theory is that the extra event in the queue is a focus or unfocus event.

We should make them all more robust to the point where they don't care/skip excess focus/unfocus events.

Contributor guide

Research direction
Investigate the flaky TestMouseWheelReadConsoleInputHelper tests by examining the test logic and focusing on handling extra focus/unfocus events in the input queue to make the tests robust.
Tech stack
None
Domain
testing
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++testingGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65