microsoft/Terminal

Safer SafeArrays

Open

#4,419 opened on Jan 30, 2020

View on GitHub
 (1 comment) (0 reactions) (1 assignee)C++ (3,212 forks)batch import
Area-CodeHealthHelp WantedIssue-TaskProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

It'd be nice if we could be safer with SafeArrays. We use them a lot in our accessibility model.

Some ideas include:

  • deleting automatically if anything goes wrong
  • easy conversions to/from vectors/arrays

I submitted an issue on wil here. If it gets implemented there first, we should use that. If not, we should just create it here and then pass it up to wil.

Contributor guide

Research direction
Investigate current SafeArray usage in the accessibility model, review the linked WIL issue for existing implementations, and consider implementing automatic deletion on error and easy conversions to/from vectors/arrays.
Tech stack
None
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40