microsoft/Terminal

Investigate and ensure `wt.exe` is always `argv[0]`

Open

#4,170 opened on Jan 9, 2020

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-CodeHealthHelp WantedIssue-TaskProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

I have seen Windows executables receive arguments BOTH ways. I don't know what the circumstance is offhand that makes it happen one way or the other. You will want to deal with both the presence and absence of your own executable name at argv[0].

Originally posted by @miniksa in https://github.com/microsoft/terminal/pull/4023

If it's not, then we'll need to mitigate this somehow, since we're leaning on that pretty hard at the moment

Contributor guide

Research direction
Investigate scenarios where argv[0] is not the executable name and identify the conditions. Ensure the terminal handles both cases.
Tech stack
cpp
Domain
cli
Issue type
Research
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
C++Windows
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50