microsoft/Terminal

Hebrew char taf ת (accessible by comma key on hebrew keyboard) appears in settings

Open

#3,733 opened on Nov 27, 2019

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-UserInterfaceHelp WantedIssue-BugPriority-3Product-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

A quick note:

First off, loving v. 0.7. Secondly, this is a ridiculously minor bug that I haven't been able to even reproduce on my own machine. Don't really bother fixing it, I guess. But it's still undefined behavior, and I thought you might want to know that something like this can happen.

Environment

Windows: Microsoft Windows [Version 10.0.18362.476]
Windows Terminal version (if applicable): 0.7.3291.0

Any other software?

Steps to reproduce

Not sure, haven't been able to reproduce it myself.

Expected behavior

Should be Ctrl+comma displayed, IIRC.

Actual behavior

A quick note: the character here, the hebrew letter taf - ת, is comma on the hebrew keyboard

image

Contributor guide

Research direction
Investigate how keyboard shortcuts are mapped and displayed in settings, focusing on handling of non US keyboard layouts.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Unclear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40