microsoft/Terminal

iTerm color schemes once more are failing to parse colors

Open

#352 opened on Jan 18, 2019

View on GitHub
 (11 comments) (3 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-SettingsHelp WantedIssue-BugProduct-ColortoolWork-Item

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Not sure if I am supposed to request to get this re-opened or if I should create another bug. But this is the same as in #2

  • Your Windows build number: (Type ver at a Windows Command Prompt) Microsoft Windows [Version 10.0.17763.253]

  • What you're doing and what's happening: (Copy & paste specific commands and their output, or include screen shots) Running: PS C:\Tools\ColorTool> .\ColorTool.exe C:\Tools\ColorTool/schemes/molokai.itermcolors Error loading ini file "C:\Tools\ColorTool/schemes/molokai.itermcolors" for key "DARK_BLACK" the value "" is invalid

The actual file contents can be found in this gist: https://gist.github.com/SneWs/4bbb50dce9a132a4dcbd07e3e2c85c44

  • What's wrong / what should be happening instead: The colors should be successfully parsed and set without any error messages being rendered.

Contributor guide

Research direction
Inspect the INI parsing logic in ColorTool (likely in the source code) to understand why a key with an empty value causes an error. Trace the parsing of itermcolors files, specifically the handling of color component values. Consider fixing the parser to accept empty strings or skip invalid keys gracefully.
Tech stack
None
Domain
clitooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++INI parsing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40