microsoft/Terminal

Showing Schemes doesn't work on WSL

Open

#312 opened on Nov 26, 2018

View on GitHub
 (1 comment) (1 reaction) (0 assignees)C++ (3,212 forks)batch import
Area-InteropHelp WantedIssue-BugPriority-3Product-Colortool

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

From #22:

@Falcury -q -x works for me, though showing schemes does not:

[rofrol@DESKTOP-NBALJ88 ~]$ pushd ~/rofrol/installed/colortool/ &> /dev/null
[rofrol@DESKTOP-NBALJ88 ~/rofrol/installed/colortool]$ ./colortool.exe -s

Unhandled Exception: System.IO.IOException: The handle is invalid.

   at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   at System.Console.GetBufferInfo(Boolean throwOnNoConsole, Boolean& succeeded)
   at System.Console.get_WindowWidth()
   at ColorTool.Program.PrintSchemes()
   at ColorTool.Program.Main(String[] args)

This should be fixed.

  • We need to add support for -s -x to print the scemes in linux-y mode
  • We should probably also catch this exception for the -s flag and properly display an error along the lines of "You should try -s -x"

Contributor guide

Research direction
Implement the s x behavior to list schemes in a Linux compatible way and catch the IOException for s to display a helpful error message.
Tech stack
csharp
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75