microsoft/Terminal

MiniTerm: ProcessFactory.Start is hard-coded to run "cmd.exe" and ignores intended parameter

Open

#307 opened on Nov 10, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-InteropHelp WantedIssue-SamplesProduct-ConptyWork-Item

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

See:

https://github.com/Microsoft/console/blob/34ff272cfa5b49dcb0bbe7aaec41797d9c285e5e/samples/ConPTY/MiniTerm/MiniTerm/Processes/ProcessFactory.cs#L21

Contributor guide

Research direction
Look at the referenced line in ProcessFactory.cs where 'cmd.exe' is hard coded and replace it with the command passed as a parameter.
Tech stack
csharp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85