microsoft/Terminal

Add a setting to manually set the Pane border width

Open

#3,063 opened on Oct 4, 2019

View on GitHub
 (2 comments) (29 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-SettingsArea-UserInterfaceHelp WantedIssue-TaskProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Follow up from #994 and PR:#3060

In the aforementioned PR, we're hardcoding the border width to 2. This should really be configurable to any positive double.

Questions:

  • (Similar to the discussion in #3061) There's been discussion before about allowing custom theming, hypothetically powered by XAML. Would we want to wait for that discussion to be had before we do this?
    • If we do want to do this in XAML later, would enabling it in the json now negatively impact that future scenario?

Contributor guide

Research direction
Examine the referenced PR #3060 to locate where the border width is hardcoded to 2. Then explore the existing settings model to understand how to add a new configurable setting.
Tech stack
cpp
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Windows Terminal
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60