microsoft/Terminal

Propagate palette changes on the legacy console through ConPTY w/ OSC 4

Open

#2,985 opened on Sep 30, 2019

View on GitHub
 (8 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-VTHelp WantedIssue-TaskProduct-Conpty

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Environment

Windows build number: Microsoft Windows [Versione 10.0.18362.356]
Windows Terminal version (if applicable): 0.5.2681.0

Any other software?
FiveM CitizenFX collective GTA Modification server Build

Steps to reproduce

using the library Colorful.Console in a c# project the output color in console is different from the color requested and in the original CMD color is correctly interpreted

Expected behavior

i expect colors to be shown correctly

Actual behavior

Colors are not correctly shown

image

image

Contributor guide

Research direction
Investigate how OSC 4 palette changes are handled in ConPTY and trace the color propagation path from the legacy console to Windows Terminal.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45