microsoft/Terminal

Re-enable C26814 for constexpr locals

Open

#2,941 opened on Sep 27, 2019

View on GitHub
 (0 comments) (0 reactions) (1 assignee)C++ (3,212 forks)batch import
Area-CodeHealthHelp WantedIssue-TaskProduct-Meta

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

This showed up in a recent compiler edition and we aren't ready for all the build breaks it is causing.

Many of the issues look fixable, but some of them look upstream in wil (though I suspect it when it says that an HR can be figured out at compile time...)

Contributor guide

Research direction
Investigate the C26814 compiler warning for constexpr locals in the Terminal codebase. Identify all offending locations and determine if they are fixable or if changes in upstream dependencies like wil are needed. Prepare a plan to re enable the warning after fixing the issues.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Windows development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30