microsoft/Terminal

[Audit] Unsuppress OuptutCellIterator warning and solve custom construction/destruction warning

Open

#2,675 opened on Sep 5, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-CodeHealthArea-OutputHelp WantedIssue-TaskProduct-ConhostProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

I suppressed the warning on the OutputCellIterator as a part of turning on audit mode because I couldn't figure it out (in a reasonable amount of time for how many other things I was fixing and trying to get turned on).

This represents removing the warning suppression and figuring out what the actual issue is that is causing the warning to flag when the iterator is advanced.

Contributor guide

Research direction
Inspect the suppressed warning in OutputCellIterator and identify why the advanced iterator triggers the warning. Then fix the warning or implement proper initialisation/destruction.
Tech stack
cpp
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65