microsoft/Terminal

[Audit] Eliminate raw pointers as begin/end markers in the CharRowCellReference class

Open

#2,672 opened on Sep 5, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-CodeHealthArea-OutputHelp WantedIssue-TaskProduct-ConhostProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

When turning on audit mode for the output buffer project, I ran into the circumstance where CharRowCellReference is using raw pointers as its iterator definitions for begin and end, which makes static analysis very unhappy as it still results in pointer math.

This represents adjusting CharRowCellReference to perform iteration in a way that audit finds palatable.

Contributor guide

Research direction
Inspect the CharRowCellReference class and its iterator definitions. Replace raw pointer begin/end markers with a suitable iterator type that avoids pointer arithmetic, such as using a wrapper or index based iterator.
Tech stack
cpp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75