microsoft/Terminal

Figure out what to do with keybindings whose characters could be triggered by multiple VKs

Open

#2,473 opened on Aug 19, 2019

View on GitHub
 (6 comments) (0 reactions) (0 assignees)C++ (3,212 forks)batch import
Area-InputHelp WantedIssue-FeatureProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

I tried to map ctrl+shift+| for vertical split but keybinding changed to \(but everything works correctly) additionally i have second backslash button between left shift and z key and using this key combination doesn't work.

Environment

Windows build number: 10.0.18963.0 Windows Terminal version (if applicable): 0.3.2171.0 Keyboard: Logitech K280e

Steps to reproduce

  1. Add binding: { "command" : "splitVertical", "keys" : [ "ctrl+shift+|" ] },
  2. Save and close settings
  3. Close Terminal
  4. Open Terminal and settings
  5. Binding looks like this: { "command" : "splitVertical", "keys" : [ "ctrl+shift+\\" ] },

No matter what during this steps left backslash never works.

Expected behavior

Keep original symbol and accept left backslash key as trigger.

Contributor guide

Research direction
Investigate the keybinding parsing logic in the terminal's settings and input handling, specifically how '|' (pipe) is converted to backslash and how multiple virtual key codes for the same character are resolved.
Tech stack
cpp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55