microsoft/Terminal

Define size for background image

Open

#2,370 opened on Aug 9, 2019

View on GitHub
 (5 comments) (3 reactions) (1 assignee)C++ (3,212 forks)batch import
Area-SettingsHelp WantedIssue-TaskProduct-Terminal

Repository metrics

Stars
 (35,764 stars)
PR merge metrics
 (Avg merge 27d 19h) (24 merged PRs in 30d)

Description

Description of the new feature/enhancement

As we are now able to define background image position using backgroundImageAlignment. It makes really easy to put an image to lower right of the terminal. It will be very appreciated to also define the size of this image. It will help to place a large image in a corner of the terminal.

Proposed technical implementation details (optional)

Add properties into the profiles.json file: eg. backgroundImageWidth and backgroundImageHeight.

Contributor guide

Research direction
Study the existing backgroundImageAlignment implementation and add new properties backgroundImageWidth and backgroundImageHeight to profiles.json, then hook them up in the rendering code.
Tech stack
None
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65